YOUR ACCOUNT

Bionic
Posts: 134
Besides duplications Group/Ungroup.

Lets say I Group/Ungroup Gain & Stones component is kept as is.

Now, lets say I Group/Ungroup Color Control & Stones.
Gain changes into a Curve Control? (they operate differently)

  Details E-Mail
Crapadilla
lvl 52 Filter Weaver and Official "Filter Forge Seer"

Posts: 4365
Filters: 65
I'm pretty sure that's a "feature".

Since the Gain remains outside of the Group, a new Curve Control must be created inside the group to accept its map input. When you ungroup, this additional Curve Control gets dumped to the work area, and the connection to Gain is broken.
--- Crapadilla says: "Damn you, stupid redundant feature requests!" ;)
  Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
Quote
Besides duplications Group/Ungroup.


Could you give more information on these duplications?

Regarding the problem at hand: this "feature" is a byproduct of our current ungrouping algorithm which is pretty dumb. When ungrouping, it just dumps controls outside the group (apparently without preserving any settings) and restores their connections exactly as they were inside the group.

This obviously isn't an optimal solution, especially for cases when the group has incoming connections from other components. Ideally, such connections should be maintained after ungrouping, not replaced with dangling control components.

However, this is a delicate matter. For example, if we chose to "maintain incoming connections after ungrouping", what do we do with the control components? If we restore the incoming connection, it will go from the originating component to the input directly, bypassing the control component. Should we delete the control component? Or just dump it somewhere nearby, unconnected?

Also, it's not always possible to maintain incoming connections after ungrouping. This is easier for Maps and Curves, but can be problematic for Numerics (gray) due to the extraneous remappers: a numeric connection to the group can have a remapper AND, inside the group, connections from the corresponding control can all have their own remappers. Basically we have two remappers between the originating output and grouped component, and during ungrouping we'll have to somehow collapse them into one.

P.S. I renamed the thread. The new name sounds a bit harsh, but I believe it will attract more viewers.
  Details E-Mail
Crapadilla
lvl 52 Filter Weaver and Official "Filter Forge Seer"

Posts: 4365
Filters: 65
Quote
[...] if we chose to "maintain incoming connections after ungrouping", what do we do with the control components?


Personally, I'd like to see the following behaviour for Groups:

Group created > Additional Control component created inside the group > incoming connection preserved.

Group destroyed > Additonal Control component destroyed > original connection restored OR control values copied to component (if no connection present).

Quote
Basically we have two remappers between the originating output and grouped component, and during ungrouping we'll have to somehow collapse them into one.


If you have two remappers, keep the one on the original component, not the one on the Group component. Collapsing them into one would be even better (but probably much harder to do).

If you have a remapper on the Group component only, move this remapper to the original component.

If you have a remapper on the original component, retain it unmodified.
--- Crapadilla says: "Damn you, stupid redundant feature requests!" ;)
  Details E-Mail

Join Our Community!

Filter Forge has a thriving, vibrant, knowledgeable user community. Feel free to join us and have fun!

33,712 Registered Users
+19 new in 30 days!

153,537 Posts
+6 new in 7 days!

15,348 Topics
+72 new in year!

Create an Account

Online Users Last minute:

21 unregistered users.