Two Crashing Bugs

I submitted two bugs that had FF crashing... Both happened while in the Filter Editor. I was trying to create a simple rust overlay filter . I had a canvas with about 10-20 nodes or so. Here's roughly (from the back of my head) what I did to produce the crash:

First Crash:

I was preperaing my filter for reuse. Meaning I put sliders and other controls in sensible areas. Then I clicked on the Result node's Filter Controls button thingy. In the component editor pane I played around with a few sliders in particular the variations. Realizing that I had given on of my subtrees a slider control for controlling variations I came to the conclusion that this control was not needed because of the global way of adjusting variations. So I deleted the slider control from the subtree. Thats when the crash occurred.

Second Crash:

Upon restarting and getting back to the state of things I was caught in the first crash (this reminds me of a suggestion: please add auto-save intervall somewhere down the roadmap) I went back to the Result node's Filter Controls. This time I tried out the Seamless Tiling checkbox. While the component's preview was refreshed I dragged the Size, pixels slider. That's when the second crash occurred.

Both crashes documented and sent via the internal crash reporter. If you need my filter to reproduce, please let me know and I'll upload it.

Let me conclude with a couple suggestions:

1) Many Mac apps that have tools modes equivalent to a hand tool or a zoom tool (see Preview.app for instance) follow the way of having Cmd+1 as the default keyboard shortcut for the tool that is displayed the furthest to the left on the tools mode toolbar. Then comes Cmd+2 for the next tool mode and so on... Maybe you could integrate that. I don't know about others but propper keyboard shortcuts whiche follow established OS standards are a biggie for my day-to-day work.

2) Concerning organization of the node tree:
Please integrate the ability to give nodes in the Filter Editor another name or maybe let us append text of our own to the filter title. Or let us give other colors to nodes. Or coming from Nuke a handy way of organizing the node tree is to create a backdrop that is just a custom resizable rectangle that goes behind all the nodes you want to group and move at once. Once you adjusted the size of this backdrop rectangle to enclose all the nodes you wanted you can now move the backdrop together with the nodes that are enclosed. And you can fold this backdrop away so it becomes one node that has multiple others in its belly. Once you get to really big node trees this is essential.

3) Please have a keyboard shortcut for temporarily disabling a node. I know you could just drag off an arrow to sever a connection but once you have a lot of trees you could accidentally remove the wrong one and not know instantly which one the severred connection as belonging to.

That's it for now

Cheers

Andre

'locked undo redo' bug ? Could you please expand that definition a little? It's just that I didn't make use of undo or redo at all when experiencing both crashes. i mean I know what an undo manager is and how you incorporate that programmatically I'm just unable to see what that means in this context.

1) Well, it doesnt matter which tool it really triggers. It's just that a switching of essential operating modes are accessed by using Cmd+<number from 1 to number of operating modes>. It should all be documented in the Apple HIG (Human Interface Guidelines, see Apple's Developer Connection).

Quote
When you change any value of a control which is covered by undo-redo, its value is stored in the undo/redo list, and fetched from there when you actually issue an undo or redo command.

Yup that's how its done. I learned it as the Command History, a variation of the Command design pattern.

Quote
The crash occurs when FF attempts to store the value in the list, not when you're using the undo/redo commands themselves.

Ahh, ok that makes more sense than the title mentioned earlier. Now I can see why you would call it like that. Thanks for explaining.

One last question:

Do I even have to post here or is it enough to just let the crash reporter do its job?